feat(bindings/nodejs): Align to OpenDAL exports #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suyanhanx
changed the title
|
Hi, please don't refactor so early. Please keep in the same file until we prepare for 0.1 release. |
suyanhanx
force-pushed
the
nodejs-binding
branch
from
e4a5b3b
to
04767fd
Compare
suyanhanx
changed the title
Xuanwo
reviewed
Mar 3, 2023
suyanhanx
force-pushed
the
nodejs-binding
branch
from
04767fd
to
a6a9076
Compare
Xuanwo
changed the title
suyanhanx
commented
Mar 4, 2023
suyanhanx
commented
Mar 4, 2023
suyanhanx
force-pushed
the
nodejs-binding
branch
2 times, most recently
from
03b559a
to
797973c
Compare
|
It seems that |
Xuanwo
reviewed
Mar 4, 2023
Xuanwo
reviewed
Mar 5, 2023
Signed-off-by: suyanhanx <[email protected]>
Signed-off-by: suyanhanx <[email protected]>
Signed-off-by: suyanhanx <[email protected]>
Signed-off-by: suyanhanx <[email protected]>
Signed-off-by: suyanhanx <[email protected]>
Signed-off-by: suyanhanx <[email protected]>
Signed-off-by: suyanhanx <[email protected]>
Signed-off-by: suyanhanx <[email protected]>
Signed-off-by: suyanhanx <[email protected]>
While we can not pass a iterator directly, return a object with next method as an alternative. Signed-off-by: suyanhanx <[email protected]>
suyanhanx
force-pushed
the
nodejs-binding
branch
from
607d169
to
6d6d052
Compare
|
Upgraded to |
Signed-off-by: suyanhanx <[email protected]>
suyanhanx
force-pushed
the
nodejs-binding
branch
from
6d6d052
to
38b8a2d
Compare
Xuanwo
approved these changes
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Summary about this PR
part of #1204
Features
Tests